this post was submitted on 28 Jul 2023
34 points (97.2% liked)

Rust

7131 readers
11 users here now

Welcome to the Rust community! This is a place to discuss about the Rust programming language.

Wormhole

!performance@programming.dev

Credits

  • The icon is a modified version of the official rust logo (changing the colors to a gradient and black background)

founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
[–] Anders429@lemmy.world 12 points 2 years ago (2 children)

We need clearer rules on which pull requests require code reviews.

Weird to me that any pull request would not require a code review.

[–] aloso@programming.dev 4 points 2 years ago

True, code for critical IT infrastructure should always be reviewed. But from what I understand, this is difficult because there is one full-time developer (paid by the Rust Foundation) and a small number of volunteers, who don't have the time to review all the employee's changes.

[–] CoderKat@lemm.ee 2 points 2 years ago* (last edited 2 years ago)

Yeah. At my current and previous jobs, literally everything going into an actual product required a code review, and that's despite all the code being written by employees that you could generally trust. Even if my boss or literally the most experienced and trusted dev wrote a commit, it still needed a review.

It's feels weird submitting my own code without a review for side projects. So many bugs have been caught by reviewers that writing code that another person would use without it being reviewed feels just wrong.