this post was submitted on 20 Mar 2026
24 points (76.1% liked)

Programming

26193 readers
287 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev

founded 2 years ago
MODERATORS
snowe@programming.dev
Ategon@programming.dev
UlrikHD@programming.dev
bugsmith@programming.dev
Spyro@programming.dev
24
Your thoughts on Code Reviews (infosec.pub)
submitted 3 days ago* (last edited 3 days ago) by mattreb@feddit.it to c/programming@programming.dev
48 comments fedilink hide all child comments
 

Hey, I want your opinion on code reviews, what is the best way to use them in a professional environment? Pick one of the following and give me your thoughts (from the most forgiving to the most strict):

  1. no code reviews, they are useless
  2. optional code reviews
  3. mandatory reviews on code that is already merged, optional fixes
  4. mandatory reviews on code before merging (like a pull request), with a time-frame for optional fixes (i.e. whether to fix what has been pointed out is up to the author), merge will occur anyway.
  5. mandatory reviews on code before merging (PR) with mandatory fixes.

Of course in open source development with public contributions, you'll often see (5), but I'm not convinced it could work in professional dev.

Edit: I'm talking about a team of 5 mid to senior devs (no junior or interns) working on a 2-3 year project without many security concerns, but feel free to give me your general opinion.

you are viewing a single comment's thread
view the rest of the comments
[โ€“] mattreb@feddit.it 1 points 3 days ago (1 children)

Added a few details in the post. Of course it depends, but let's say you're the team lead and you have to fix a general rule (otherwise no one is going to do them) which one you're more likely to go for? e.g. if you choose (2), it's up to every single member.

Q: about #3

yes already merged, updated the post.

[โ€“] eager_eagle@lemmy.world 3 points 3 days ago

The way I see it, for any code review there are going to be different levels of recommendation regarding the comments. When I review, I try to make it clear what's optional (/ nitpick) and what I'd really like to see fixed before I can approve it.

So even making some assumptions, I can't choose between 4 and 5 because optional and "less optional" changes are often in a same PR.

The only one I haven't done much of is #3. That one looks better if one has questions about code that was already reviewed, merged, and it's likely in production.