this post was submitted on 20 Mar 2026
24 points (76.1% liked)

Programming

26193 readers
187 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev

founded 2 years ago
MODERATORS
snowe@programming.dev
Ategon@programming.dev
UlrikHD@programming.dev
bugsmith@programming.dev
Spyro@programming.dev
24
Your thoughts on Code Reviews (infosec.pub)
submitted 3 days ago* (last edited 3 days ago) by mattreb@feddit.it to c/programming@programming.dev
48 comments fedilink hide all child comments
 

Hey, I want your opinion on code reviews, what is the best way to use them in a professional environment? Pick one of the following and give me your thoughts (from the most forgiving to the most strict):

  1. no code reviews, they are useless
  2. optional code reviews
  3. mandatory reviews on code that is already merged, optional fixes
  4. mandatory reviews on code before merging (like a pull request), with a time-frame for optional fixes (i.e. whether to fix what has been pointed out is up to the author), merge will occur anyway.
  5. mandatory reviews on code before merging (PR) with mandatory fixes.

Of course in open source development with public contributions, you'll often see (5), but I'm not convinced it could work in professional dev.

Edit: I'm talking about a team of 5 mid to senior devs (no junior or interns) working on a 2-3 year project without many security concerns, but feel free to give me your general opinion.

you are viewing a single comment's thread
view the rest of the comments
[–] litchralee@sh.itjust.works 2 points 3 days ago* (last edited 3 days ago)

but what if for example an issue is internal to a WIP feature?

I forgot to answer this. The question is always: will this materially impact the deliverable? Will the customer be unhappy if they hit this bug?

If the WIP feature isn't declared to be fully working yet, then sure, let it on the branch and create a ticket to fix this particular bug. But closed-loop requires making this ticket, as a reminder to follow it up later, when the feature is almost complete.

If instead the bug would be catastrophic but is exceptionally rare, then that's a tough call. But that's precisely why the call should involve more people, not less. A single person making a tough call is always a risky endeavor. Better to get more people's input and hopefully make a collective choice. Also, humans too often play the blame-game if there isn't a joint, transparent decision making process.

But where would all these people convene to make a collective choice? How about during code review?