this post was submitted on 31 Mar 2026
139 points (99.3% liked)
Programming
26304 readers
692 users here now
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.
Hope you enjoy the instance!
Rules
Rules
- Follow the programming.dev instance rules
- Keep content related to programming in some way
- If you're posting long videos try to add in some form of tldr for those who don't want to watch videos
Wormhole
Follow the wormhole through a path of communities !webdev@programming.dev
founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
The signal-to-noise ratio of reviews is nearly zero in my experience. It’s for the least productive people on the team to argue about spaces or gotos or grind other ideological axes.
I find PRs really dumb things down, but not in a way that makes code more understandable. And it certainly doesn’t improve quality.
My last job was pretty good about code reviews, when people actually spent time on them. My front end code got much better when the front-end expert actually reviewed it.
My current job, code reviews are a rubber stamp farce and I've seen total garbage sail though. The code base is a tire fire. These things are related.
If your team is only focused on tabs/spaces or soapboxing during code reviews, you have bigger issues to take care of.
Show me a place where this isn’t the case. Because I’ve never seen it not be the case in 20+ years in the field.
15+ years in engineering here. 10+ in leadership.
Code formatting hasn't been an issue since the early '10s. Tabs or spaces? Who cares. Your editor can make it look like whatever you want and it won't effect the code.
As for other asshole-ish behavior or gatekeeping, I open it up to a vote. Let the team determine best practices. Don't like what your team decides? Find another team to shitlord over.
A good alternative is code presentations.
You present your changes to a group of engineers. Then discuss it.
Yes, it happens too often. That’s a failure of leadership or a social problem.
Techies often try and fix human and social issues with technology, but that doesn’t always work.
Code review helps spread knowledge about the code base through the team. Without it, you easily end up with disjointed fiefdoms ruled by petty code lords that don’t share information.
Spreading knowledge and context sharing are exactly why I like code reviews. It should also be something done by more than one person so that information is better disseminated throughout the team.
Code presentations are great for that.
One or two people present their code before the merge. Others watch, ask questions, etc. Small changes and improvements can be done immediately. Ideally the change is merged after the presentation. It can speed up things immensely and more people feel ownership. If a simple ticket stays in review for a week, it can be very detrimental.
I mean, what we have now is a clique of ideologically-aligned people who insta-approve each other’s bad PRs outside their domain and ignore or jam-up the PRs of people outside their clique.
You can say it’s a failure of management, but this is the primary tool used by the ideologues. And I’ve seen it used so at various places.
What I haven’t seen is a real dissemination of knowledge about the code via review. At least not above and beyond what can be achieved by looking at the code and using blame to see the changesets and looking at the associated issues.
This kind of social behavior is corporate politics and a failure of management of course.
Okay, I’ll go tell management they’ve failed. 🙄
That's an engineering culture problem. Not a PR problem.