Programming

The problem of deciding what should be merged or blocked

If you want to merge something and I read it over and reject the PR because you forgot about concurrency, that doesn’t mean you don’t get to merge, it means that it’s not finished baking. And assuming you give a shit about the code your response should be “oh shit, lemme fix that and resubmit” OR “actually this code will never have concurrent access, and here’s why.” You’re making this process sound adversarial when it isn’t. It’s a group effort. Everyone wins or loses together.

You're obviously right, you're misunderstanding me. With blocked I didn't meant "forever", I meant until the issues is discussed. I'm merely asking how the reviewer is making the call on what should be addressed before merge in #5

If there is work that needs to be done, and you are asked to do it, the code will be merged when it’s right. I don’t decide what to merge, I decide when something is ready to merge.

you're really nitpicking my English, which I know is not great, but yeah that's what I was asking, so you use #5 with a single person making the final call on when something is ready.

You’re making this process sound adversarial when it isn’t.

Absolutely not, I've never said or thought that. But of course development is made of people and computers can only tell you what compiles, not "when it's right" as you say. So of course I'm more curious to understand how to solve situations when you do have conflict, if you don't it's easy.